Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce unnecessary code and fix a typo #655

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Reduce unnecessary code and fix a typo #655

merged 1 commit into from
Feb 17, 2024

Conversation

danieldouglas92
Copy link
Contributor

No description provided.

MFraters
MFraters approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are removing a *1? Hope the tests are not breaking because of that ;)

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 17, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6678d19) 92.82% compared to head (d134665) 92.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   92.82%   92.78%   -0.05%     
==========================================
  Files         105      105              
  Lines        7182     7177       -5     
==========================================
- Hits         6667     6659       -8     
- Misses        515      518       +3
Files Coverage Δ
...eanic_plate_models/temperature/half_space_model.cc 98.43% <100.00%> (-0.05%) ⬇️
...es/oceanic_plate_models/temperature/plate_model.cc 100.00% <100.00%> (ø)
...ucting_plate_models/temperature/mass_conserving.cc 98.62% <100.00%> (-0.02%) ⬇️
source/world_builder/utilities.cc 97.15% <100.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6678d19...d134665. Read the comment docs.

@github-actions GitHub Actions
Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.019 ± 0.003 (s=429) 1.012 ± 0.003 (s=460) -0.8% .. -0.6%
Slab interpolation curved simple none 1.024 ± 0.004 (s=429) 1.017 ± 0.004 (s=455) -0.8% .. -0.6%
Spherical slab interpolation simple none 1.168 ± 0.015 (s=417) 1.164 ± 0.008 (s=357) -0.6% .. -0.1%
Slab interpolation simple curved CMS 1.058 ± 0.006 (s=398) 1.060 ± 0.005 (s=454) +0.0% .. +0.3%
Spherical slab interpolation simple CMS 1.546 ± 0.010 (s=297) 1.545 ± 0.010 (s=288) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.171 ± 0.009 (s=378) 1.170 ± 0.007 (s=393) -0.2% .. +0.1%
Cartesian min max surface 2.301 ± 0.021 (s=191) 2.304 ± 0.027 (s=202) -0.2% .. +0.5%
Spherical min max surface 7.205 ± 0.029 (s=68) 7.203 ± 0.034 (s=59) -0.3% .. +0.2%

@MFraters MFraters merged commit 6fc135f into GeodynamicWorldBuilder:main Feb 17, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFraters MFraters MFraters approved these changes

Assignees
No one assigned
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieldouglas92 @MFraters